From: Georges Basile Stavracas Neto Date: Wed, 24 Jun 2020 18:32:27 +0000 (-0300) Subject: appDisplay: Update folder dialog field before ungrabbing X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~684^2^2~207 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=8f8ecdb9836e984df25b3031292afb5f792291ab;p=gnome-shell.git appDisplay: Update folder dialog field before ungrabbing Noticed while working on customizable folders. Calling GrabHelper.ungrab() ends up calling FolderDialog.popdown(), but at this point the '_isOpen' field isn't updated yet, so we end up calling popdown() twice. Update the '_isOpen' field before ungrabbing. https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1332 --- diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js index ff813f395..807c43a53 100644 --- a/js/ui/appDisplay.js +++ b/js/ui/appDisplay.js @@ -1782,8 +1782,8 @@ var AppFolderDialog = GObject.registerClass({ this._zoomAndFadeOut(); this._showFolderLabel(); - this._grabHelper.ungrab({ actor: this }); this._isOpen = false; + this._grabHelper.ungrab({ actor: this }); this.emit('open-state-changed', false); } });